Add col current_run_uuid to jobs#2929
Merged
Merged
Conversation
Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2929 +/- ##
============================================
+ Coverage 81.12% 81.13% +0.01%
- Complexity 1505 1507 +2
============================================
Files 268 268
Lines 7358 7364 +6
Branches 330 330
============================================
+ Hits 5969 5975 +6
Misses 1228 1228
Partials 161 161 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>
Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
* Add col current_run_uuid to jobs Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Apply formatting Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> --------- Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>
jni-bot
added a commit
to jni-bot/marquez
that referenced
this pull request
Feb 12, 2026
…roject#2987) The findByLatestJob query was scanning millions of rows in run_facets and dataset_facets by joining runs_view with jobs_view in the WHERE clause. This caused 7+ minute query times per job, making the jobs list page unusable at scale. Two changes: - Add findCurrentRunByJob using jobs.current_run_uuid (from MarquezProject#2929) for the jobs list page, reducing it to a single indexed UUID lookup - Optimize findByLatestJob to filter on runs.job_uuid (indexed) with symlink resolution, instead of the expensive runs_view/jobs_view join Closes MarquezProject#2987 Signed-off-by: jni-bot <jni-bot@users.noreply.github.com>
4 tasks
merobi-hub
added a commit
that referenced
this pull request
Apr 12, 2026
…3091) The findByLatestJob query was scanning millions of rows in run_facets and dataset_facets by joining runs_view with jobs_view in the WHERE clause. This caused 7+ minute query times per job, making the jobs list page unusable at scale. Two changes: - Add findCurrentRunByJob using jobs.current_run_uuid (from #2929) for the jobs list page, reducing it to a single indexed UUID lookup - Optimize findByLatestJob to filter on runs.job_uuid (indexed) with symlink resolution, instead of the expensive runs_view/jobs_view join Closes #2987 Signed-off-by: jni-bot <jni-bot@users.noreply.github.com> Co-authored-by: jni-bot <jni-bot@users.noreply.github.com> Co-authored-by: Michael Robinson <68482867+merobi-hub@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a slightly optimized approach replacing #2928 by adding
jobs.current_run_uuid.SQLPerfEXPLAINplanThis PR also updates how the job type is display within the jobs list: