Skip to content

Fixing latestRun on /lineage endpoint#2933

Merged
wslulciuc merged 4 commits into
mainfrom
fix/lineage-runs
Oct 18, 2024
Merged

Fixing latestRun on /lineage endpoint#2933
wslulciuc merged 4 commits into
mainfrom
fix/lineage-runs

Conversation

@phixMe

@phixMe phixMe commented Oct 18, 2024

Copy link
Copy Markdown
Member

Problem

Simplify our query to render lineage and not include facets. Correctly attribute runs of jobs that are currently in RUNNING status.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>
@boring-cyborg boring-cyborg Bot added the api API layer changes label Oct 18, 2024
@netlify

netlify Bot commented Oct 18, 2024

Copy link
Copy Markdown

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit d4e319f
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/6711bb06f807fd0008c18241

Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>
Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>
Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>
@codecov

codecov Bot commented Oct 18, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.12%. Comparing base (da39558) to head (d4e319f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2933      +/-   ##
============================================
- Coverage     81.13%   81.12%   -0.01%     
+ Complexity     1507     1506       -1     
============================================
  Files           268      268              
  Lines          7367     7365       -2     
  Branches        330      329       -1     
============================================
- Hits           5977     5975       -2     
  Misses         1229     1229              
  Partials        161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc added this to the 0.50.0 milestone Oct 18, 2024

@wslulciuc wslulciuc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wslulciuc wslulciuc merged commit 39ddd65 into main Oct 18, 2024
@wslulciuc wslulciuc deleted the fix/lineage-runs branch October 18, 2024 01:50
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
* Fixing lineage latest run.

Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>

* Test fixes.

Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>

* Fixing minor sorting error.

Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>

* Removing assertions on facets that are no longer included.

Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>

---------

Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api API layer changes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants