Skip to content

fix: remove 10k drawer cap from status display#707

Merged
milla-jovovich merged 1 commit intoMemPalace:developfrom
sanjay3290:fix/status-count-cap
Apr 13, 2026
Merged

fix: remove 10k drawer cap from status display#707
milla-jovovich merged 1 commit intoMemPalace:developfrom
sanjay3290:fix/status-count-cap

Conversation

@sanjay3290
Copy link
Copy Markdown
Contributor

Summary

  • mempalace status was hardcoded with col.get(limit=10000, ...) in miner.py, which capped the drawer count at 10,000 regardless of actual collection size
  • Replaced with col.count() to get the true total, then pass that as the limit to col.get() so the wing/room breakdown includes all drawers
  • I confirmed this with a 91k drawer palace — status now correctly reports 91,202 drawers instead of 10,000

Fixes #603

Test plan

  • Verified col.count() is the standard pattern used across the codebase (repair.py, dedup.py, layers.py, etc.)
  • Handles empty collections gracefully (guard with if total before calling col.get())
  • Run mempalace status on a palace with >10k drawers to confirm correct count

@milla-jovovich milla-jovovich merged commit 3a50966 into MemPalace:develop Apr 13, 2026
6 checks passed
igorls added a commit that referenced this pull request Apr 13, 2026
PR #761 bumped pyproject.toml to 3.2.0 but missed three other version strings,
causing test_version_consistency to fail on develop CI (macos, linux 3.11, windows).

- mempalace/version.py: 3.1.0 → 3.2.0 (unblocks test_version_consistency)
- README.md: version badge shield 3.1.0 → 3.2.0
- integrations/openclaw/SKILL.md: 3.1.0 → 3.2.0
- CHANGELOG.md: rename [Unreleased] → [3.2.0] — 2026-04-13, add entries
  for #685, #690, #707, #716, #734, #755, #757, #761

Verified locally: 689/689 tests pass, ruff clean.
@igorls igorls mentioned this pull request Apr 13, 2026
4 tasks
henryabra added a commit to henryabra/mempalace that referenced this pull request Apr 13, 2026
…alaces

PR MemPalace#707 removed the 10k drawer cap and replaced `limit=10000` with
`limit=total`, which correctly shows all drawers but crashes with
`chromadb.errors.InternalError: too many SQL variables` when the palace
has more than ~40k drawers (SQLite's SQLITE_MAX_VARIABLE_NUMBER default
is 32766).

Fetch metadata in batches of 5000 using ChromaDB's `offset` parameter.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sha2fiddy pushed a commit to sha2fiddy/mempalace that referenced this pull request Apr 13, 2026
PR MemPalace#761 bumped pyproject.toml to 3.2.0 but missed three other version strings,
causing test_version_consistency to fail on develop CI (macos, linux 3.11, windows).

- mempalace/version.py: 3.1.0 → 3.2.0 (unblocks test_version_consistency)
- README.md: version badge shield 3.1.0 → 3.2.0
- integrations/openclaw/SKILL.md: 3.1.0 → 3.2.0
- CHANGELOG.md: rename [Unreleased] → [3.2.0] — 2026-04-13, add entries
  for MemPalace#685, MemPalace#690, MemPalace#707, MemPalace#716, MemPalace#734, MemPalace#755, MemPalace#757, MemPalace#761

Verified locally: 689/689 tests pass, ruff clean.
sha2fiddy pushed a commit to sha2fiddy/mempalace that referenced this pull request Apr 14, 2026
PR MemPalace#761 bumped pyproject.toml to 3.2.0 but missed three other version strings,
causing test_version_consistency to fail on develop CI (macos, linux 3.11, windows).

- mempalace/version.py: 3.1.0 → 3.2.0 (unblocks test_version_consistency)
- README.md: version badge shield 3.1.0 → 3.2.0
- integrations/openclaw/SKILL.md: 3.1.0 → 3.2.0
- CHANGELOG.md: rename [Unreleased] → [3.2.0] — 2026-04-13, add entries
  for MemPalace#685, MemPalace#690, MemPalace#707, MemPalace#716, MemPalace#734, MemPalace#755, MemPalace#757, MemPalace#761

Verified locally: 689/689 tests pass, ruff clean.
igorls added a commit that referenced this pull request Apr 14, 2026
Main had 9 commits that never back-merged into develop after the v3.2.0
release cycle. Resolving conflicts as follows:

- mempalace/version.py: keep develop (3.3.0 release target)
- README.md: keep develop (Milla's #835 audit is authoritative — main
  had stale 19 tools / 170 tokens / "30x lossless" / v3.0.0 label)
- hooks/mempal_{save,precompact}_hook.sh: keep develop (#786 reversed
  the #666 "decision=block" behavior intentionally to stop hooks from
  making agents write in chat)
- pyproject.toml: auto-merged — keeps develop's 3.3.0 and picks up
  main's chromadb upper-bound removal (#690)
- CONTRIBUTING.md, mempalace/hooks_cli.py: auto-merged cleanly —
  picks up main's improvements (fork-first clone, more detailed
  block reason strings that name MemPalace and specific tools)
- integrations/openclaw/SKILL.md: bumped 3.2.0 → 3.3.0 (version
  tracks the package per #761 convention)
- CHANGELOG.md: manual merge — kept develop's preamble + Unreleased
  v3.3.0 section + footer links; folded main's richer v3.2.0 entries
  (Packaging section for #690/#761; Bug Fixes #685/#677/#716/#707/
  #755/#757; Documentation #734/#733) into the v3.2.0 section;
  deduped the split Documentation sections that auto-merge produced
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mempalace status count less

2 participants