Skip to content

⚡ Optimize regex compilation in entity extraction#880

Merged
igorls merged 1 commit intodevelopfrom
perf-optimize-regex-compilation-15578943484596502942
Apr 14, 2026
Merged

⚡ Optimize regex compilation in entity extraction#880
igorls merged 1 commit intodevelopfrom
perf-optimize-regex-compilation-15578943484596502942

Conversation

@igorls
Copy link
Copy Markdown
Member

@igorls igorls commented Apr 14, 2026

💡 What: Optimized Dialect._detect_entities_in_text by moving re.compile(r"[^a-zA-Z]") out of the inner loop and defining it at the module level as _ALPHA_RE.

🎯 Why: Inside the fallback loop for finding capitalized words, re.sub(r"[^a-zA-Z]", "", w) was being called. This implicitly compiles the regex pattern on every iteration, leading to unnecessary overhead, especially for long texts.

📊 Measured Improvement:
Baseline measured execution time:

  • ~0.26 seconds for 10,000 iterations
  • ~2.57 seconds for 100,000 iterations

Optimized measured execution time:

  • ~0.15 seconds for 10,000 iterations
  • ~1.45 seconds for 100,000 iterations

The change provides nearly a 2x performance speedup for this function by eliminating redundant regex compilation.


PR created automatically by Jules for task 15578943484596502942 started by @igorls

Move regular expression compilation to the module level in `dialect.py` to prevent repeated parsing during loop execution.

Co-authored-by: igorls <4753812+igorls@users.noreply.github.com>
@igorls igorls requested a review from milla-jovovich as a code owner April 14, 2026 17:43
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@igorls igorls requested a review from bensig as a code owner April 14, 2026 17:43
@igorls igorls added performance Performance improvements enhancement New feature or request labels Apr 14, 2026
@igorls igorls merged commit c9b3245 into develop Apr 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request performance Performance improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant