Fix stale status display by paginating drawer metadata#892
Closed
ldtalexthip wants to merge 1 commit intoMemPalace:developfrom
Closed
Fix stale status display by paginating drawer metadata#892ldtalexthip wants to merge 1 commit intoMemPalace:developfrom
ldtalexthip wants to merge 1 commit intoMemPalace:developfrom
Conversation
The status command was hard-capped at 10,000 drawers via col.get(limit=10000), so any palace larger than that would display an undercount and room totals would freeze at whatever fell inside the first 10k page. Paginate in 5,000-drawer chunks up to col.count() so the reported totals match what is actually in Chroma. Before: MemPalace Status — 10000 drawers (capped) After: MemPalace Status — 45743 drawers (accurate)
Collaborator
|
closing in favor of #851 which covers the same status pagination fix and is mergeable. thanks @ldtalexthip! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mempalace statushard-capscol.get(limit=10000, ...)which makes the header literally displayMemPalace Status — 10000 drawersonce a palace exceeds 10k drawers.col.count()so the reported totals match what's actually stored.Before:
After:
Test plan
mempalace statusagainst a palace with >10k drawers — totals now matchcol.count()offset=0, then exit