fix: Incorrect order of indices used in TSPTW model#4
Open
ImkoMarijnissen wants to merge 1 commit intoMiniZinc:developfrom
Open
fix: Incorrect order of indices used in TSPTW model#4ImkoMarijnissen wants to merge 1 commit intoMiniZinc:developfrom
ImkoMarijnissen wants to merge 1 commit intoMiniZinc:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The indexing used in the
tsptw.mznmodel from the 2025 challenge uses the wrong order for the indices definingdurToPred.While this does not lead to any incorrect solutions when using a symmetric distance matrix (as is the case for all the instances in the 2025 MiniZinc Challenge), it does lead to issues on other instance sets in the literature.
This fix does not lead to any changes in the produced flatzinc file for the instances used in the challenge, but it might be able to prevent people from running into this issue when reusing this model!