fix: coerce env values to string before .includes() check in updateENV#5310
Closed
xandr0s wants to merge 1 commit intoMintplex-Labs:masterfrom
Closed
fix: coerce env values to string before .includes() check in updateENV#5310xandr0s wants to merge 1 commit intoMintplex-Labs:masterfrom
xandr0s wants to merge 1 commit intoMintplex-Labs:masterfrom
Conversation
POST /api/v1/system/update-env crashes with 500 when numeric values are passed (e.g. GenericOpenAiEmbeddingMaxConcurrentChunks: 1). Number type has no .includes() method — wrapping with String() fixes it.
Member
|
You shouldn't be using the frontend API directly outside the UI because of things like this - what is the use case you are working for where you need to manipulate the update-env directly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/v1/system/update-envwhen numeric values are passed.includes("******")called on Number type — Number has no.includes()methodString()before calling.includes()Steps to reproduce
Change
Test plan
/api/v1/system/update-env— no crash, value saved******— still filtered correctly