Implement sead/time/seadCalendarTime.o

[MonsterDruide1]

The following functions should be listed in this object:

status	address	function	size (bytes)
✅	0x7100764174	sead::CalendarTime::Year::setValue(unsigned int)	8
✅	0x710076417C	sead::CalendarTime::Month::Month(unsigned int)	8
✅	0x7100764184	sead::CalendarTime::Month::setValueOneOrigin(unsigned int)	8
✅	0x710076418C	sead::CalendarTime::Month::addSelf(unsigned int)	60
✅	0x71007641C8	sead::CalendarTime::Month::subSelf(unsigned int)	104
✅	0x7100764230	sead::CalendarTime::Month::sub(sead::CalendarTime::Month) const	12
✅	0x710076423C	sead::CalendarTime::Month::makeStringOneOrigin(unsigned int)	280
✅	0x7100764354	sead::CalendarTime::Month::makeFromValueOneOrigin(unsigned int)	8
✅	0x710076435C	sead::CalendarTime::Day::setValue(unsigned int)	8
✅	0x7100764364	sead::CalendarTime::Hour::setValue(unsigned int)	8
✅	0x710076436C	sead::CalendarTime::Minute::setValue(unsigned int)	8
✅	0x7100764374	sead::CalendarTime::Second::setValue(unsigned int)	8
✅	0x710076437C	sead::CalendarTime::Date::Date(sead::CalendarTime::Year const&, sead::CalendarTime::Month const&, sead::CalendarTime::Day const&)	72
✅	0x71007643C4	sead::CalendarTime::Time::Time(sead::CalendarTime::Hour const&, sead::CalendarTime::Minute const&, sead::CalendarTime::Second const&)	28
✅	0x71007643E0	sead::CalendarTime::CalendarTime(sead::CalendarTime::Date const&, sead::CalendarTime::Time const&)	80
✅	0x7100764430	sead::CalendarTime::Date::calcWeek()	44
✅	0x710076445C	sead::CalendarTime::CalendarTime(sead::CalendarTime::Year const&, sead::CalendarTime::Month const&, sead::CalendarTime::Day const&, sead::CalendarTime::Hour const&, sead::CalendarTime::Minute const&, sead::CalendarTime::Second const&)	116
✅	0x71007644D0	sead::CalendarTime::setDate(sead::CalendarTime::Date const&)	60
✅	0x710076450C	sead::CalendarTime::getYearDays() const	76
✅	0x7100764558	sead::CalendarTime::makeWeekDayNameLabel_(sead::BufferedSafeStringBase<char>*, sead::CalendarTime::Week)	36
⬜	0x710076457C		276

[MonsterDruide1]

The file's initializer is missing here. The constants like cMonth_May are supposed to be located in .bss and initialized at startup - however, they are currently located at .rodata.

Removing const from the constant's qualifiers allows moving Hour, Minute and Second to .bss, but they remain uninitialized then for some reason - and Day, Year and Month are placed on .data instead (with values already applied).

I haven't been able to figure out why, if anyone else wants to take a shot - go ahead!

[Fuzzy2319]

it means they are static instead of const

[MonsterDruide1]

They are static const at the moment:
https://github.com/open-ead/sead/blob/master/include/time/seadCalendarTime.h#L91-L109

Removing const leaves them with static, which is exactly what I tried and what you suggested.

[Fuzzy2319]

I checked in the cpp and it looks like the static keyword is missing

[Fuzzy2319]

ok found it

[MonsterDruide1]

Oh, great! Can you create a sead PR from the fix?

[github-actions]

@Fuzzy2319 @MonsterDruide1 Warning: This issue is now assigned to more than one person! Please make sure you're not working on the same functions.