Skip to content

bug: list-patches w/url on v1.9.0 returns: Illegal input: Unexpected JSON token at offset 3: Encountered an unknown key 'url' at path: #172

@nova2moon

Description

@nova2moon

Bug description

Using older 1.8.1 it was possible to list patches using URL of patches without downloading locally, e.g:

java -jar ./morphe-cli-1.8.1-all.jar list-patches --with-packages --with-versions --with-options --patches=https://github.com/MorpheApp/morphe-patches

which would list the patches:

`INFO: Using cached patch file at morphe-temporary-files/download/MorpheApp-morphe-patches/patches-1.30.0.mpp
INFO: Index: 0
Name: Override certificate pinning
Description: Overrides certificate pinning, allowing to inspect traffic via a proxy.
Enabled: false

Index: 1
Name: Change package name
`
In 1.9.0 it fails see below

Error logs

`java -jar ./morphe-cli-1.9.0-all.jar list-patches --with-packages --with-versions --with-options --patches=https://github.com/MorpheApp/morphe-patches
INFO: Morphe data root: /home/jupiter/morphe/morphe-data (JAR-adjacent) 
INFO: GitHub: fetching releases from https://api.github.com/repos/MorpheApp/morphe-patches/releases 
WARNING: GitHub releases fetch error for MorpheApp/morphe-patches: Illegal input: Unexpected JSON token at offset 3: Encountered an unknown key 'url' at path: $[0]
Use 'ignoreUnknownKeys = true' in 'Json {}' builder or '@JsonIgnoreUnknownKeys' annotation to ignore unknown keys.
JSON input: [{"url":"https://api.github.com/r..... 
Failed to download patches from URL: Illegal input: Unexpected JSON token at offset 3: Encountered an unknown key 'url' at path: $[0]
Use 'ignoreUnknownKeys = true' in 'Json {}' builder or '@JsonIgnoreUnknownKeys' annotation to ignore unknown keys.
JSON input: [{"url":"https://api.github.com/r.....
Usage: morphe-cli list-patches [-diopuv] [--prerelease] [-f=<packageName>]
                               [--out=<outputFile>] [-t=<temporaryFilesPath>]
                               --patches=<patchesFile>...
                               [--patches=<patchesFile>...]...
`

Also tried the full path to patches file, e.g.
--patches="https://github.com/MorpheApp/morphe-patches/releases/download/v1.30.0/patches-1.30.0.mpp"

fails in same way.

Solution

wget the patches locally and --patches=patches-1.30.0.mpp works without errors and lists the patches.

Additional context

No response

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions