feat: add settings screen back button#567
Conversation
|
Thank you so much, I was going to open an issue on this but I guess I don't have to being blind and all that, I physically don't know how to use the back gesture so I back button for settings is super nice though. To be fair, it wasn't a huge issue because I didn't enter the settings too often |
|
This PR seems to be generated by AI. Currently, some redesign has been done in the dev version, but we don't have a concept for adding such a button to the current settings yet. The standard toolbar (added as I understood in this PR) is not suitable in terms of design. We are open to suggestions, preferably with a visual preview. |
|
Thanks for the feedback. That makes sense.
I’ll revisit the approach and make sure it fits the current dev redesign instead of adding a generic toolbar/header.
…________________________________
From: MarcaDian ***@***.***>
Sent: Tuesday, May 19, 2026 10:04 PM
To: MorpheApp/morphe-manager ***@***.***>
Cc: Zaid AlAsali ***@***.***>; Author ***@***.***>
Subject: Re: [MorpheApp/morphe-manager] feat: add settings screen back button (PR #567)
[https://avatars.githubusercontent.com/u/152095496?s=20&v=4]MarcaDian left a comment (MorpheApp/morphe-manager#567)<#567 (comment)>
This PR seems to be generated by AI. Currently, some redesign has been done in the dev version, but we don't have a concept for adding such a button to the current settings yet. The standard toolbar (added as I understood in this PR) is not suitable in terms of design. We are open to suggestions, preferably with a visual preview.
—
Reply to this email directly, view it on GitHub<#567 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A6FDZFEX6GAFLNAXAGHGA6T43S43ZAVCNFSM6AAAAACZE2PJ6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DIOJRGU3TEMZUGE>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
I tried adding the back button to the bottom tab bar, so that it wasn't in a separate header, I don't know how correct that is. This button is read first in Talkback as if it were at the top, so there shouldn't be any problems for blind users with screen readers. Screenshots
|
|
A back button on the buttom nav bar is unusual, and I agree I don't think it would look good with a top nav bar either. Maybe we will figure out a different solution that isn't an explicit back button at all. |
|
As a separate solution for screen readers, we could add an invisible back button. But some sighted users might want a visible button, so this is a controversial solution. |
|
Let you guys know that when a back button in the YouTube settings, like the custom settings menu you guys have, there is a back button. I can tell it's the back button, but not because it's labeled, specifically because it's the only unlabeled button. So I literally have to distinguish the back button by the fact that it's unlabeled, same with the refresh video button in the video player. That is basically the only issue I've seen. I'm still having the issue where occasionally when entering comments the application will crash. Although I still think that's an Android 17 bug, but it seems to be less frequent now so I don't know what's up with that. And earlier today I had a bug where literally when I turned up the volume it crashed my application |
|
What I mentioned also has to do also occurs with the save to watch later button. I just forgot to mention that cuz I don't use that button |
|
How does this apply to the Morphe Manager? |
|
It doesn't but it's just something I'm pointing out because it has the exact same issue and I don't want the buttons here to be issue that the button's there have of no labels |
|
Thanks for looking into this and for trying another placement.
I agree that both a separate top toolbar and a back button inside the bottom bar may not be the right fit visually. I opened this mainly because the accessibility/use-case seemed valid, but I’m happy to rework the PR around whatever direction fits the current dev redesign best, or close it if you prefer to handle the navigation pattern separately.
If helpful, I can also turn this into a smaller accessibility-focused change instead of a visible UI change.
…________________________________
From: MarcaDian ***@***.***>
Sent: Wednesday, May 20, 2026 12:22 AM
To: MorpheApp/morphe-manager ***@***.***>
Cc: Zaid AlAsali ***@***.***>; Author ***@***.***>
Subject: Re: [MorpheApp/morphe-manager] feat: add settings screen back button (PR #567)
[https://avatars.githubusercontent.com/u/152095496?s=20&v=4]MarcaDian left a comment (MorpheApp/morphe-manager#567)<#567 (comment)>
How does this apply to the Morphe Manager?
—
Reply to this email directly, view it on GitHub<#567 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A6FDZFGPNEWOSTGHZHFRLQT43TNEBAVCNFSM6AAAAACZE2PJ6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DIOJSGU2TSOJZGM>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
MarcaDian
force-pushed
the
dev
branch
3 times, most recently
from
5b596a7 to
6ca5114
Compare
4 participants
Summary
Adds a visible back button to the settings screen.
This gives users a clear way to return from settings without relying only on system gestures or navigation buttons, improving accessibility and discoverability.
Closes #396.
Testing
git diff --checkSettingsScreencall site is updatedSettingsScreendid not already have a top app bar/header.\gradlew.bat :app:compileDebugKotlin, but local Android SDK configuration is missing:SDK location not found. Define a valid SDK location with an ANDROID_HOME environment variable or local.properties.