Skip to content

fix(Change start page): Route back button to exit the app#1195

Draft
ILoveOpenSourceApplications wants to merge 53 commits into
devfrom
fix/change-start-page
Draft

fix(Change start page): Route back button to exit the app#1195
ILoveOpenSourceApplications wants to merge 53 commits into
devfrom
fix/change-start-page

Conversation

@ILoveOpenSourceApplications

@ILoveOpenSourceApplications ILoveOpenSourceApplications commented Apr 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Closes #1001.

Additional context

Intercepts onBackPressed in MusicActivity before the app closes. If the user is at the root of a custom start page, it routes them to FEmusic_home instead. Ported the appLaunched state logic from YouTube to prevent the override from trapping the user.

Test results

  • Tested on both the minimum and maximum supported versions
  • Tested on experimental supported versions (Optional)

@ILoveOpenSourceApplications ILoveOpenSourceApplications linked an issue Apr 16, 2026 that may be closed by this pull request
bug(YouTube Music): Setting start page to Charts while navigation bar is hidden, makes going to the settings impossible #1001
Closed
2 tasks
@LisoUseInAIKyrios

LisoUseInAIKyrios commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

The patch was crashing on startup with 9.15 (back button register is not the expected type), and after fixing the crash the patch doesn't seem to work if Always change start page is turned off.

Patch doesn't seem to always change start page either. I'm not sure if the problem is fixing 9.15 or if something else is going on.

@LisoUseInAIKyrios

LisoUseInAIKyrios commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Neither overrideIntentActionOnCreate or overrideBrowseId are being called when the app is resumed.

@ILoveOpenSourceApplications

ILoveOpenSourceApplications commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

I made the changes based off of the patch for YouTube. I guess it still needs more testing.

@ILoveOpenSourceApplications ILoveOpenSourceApplications marked this pull request as draft April 20, 2026 09:42
@ILoveOpenSourceApplications
Merge remote-tracking branch 'upstream/fix/change-start-page' into fi…
7aa656b 
…x/change-start-page

# Conflicts:
#	extensions/music/src/main/java/app/morphe/extension/music/patches/ChangeStartPagePatch.java
@ILoveOpenSourceApplications

ILoveOpenSourceApplications commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

"WARNING: Track crossfade is not yet available for YouTube Music 9.x. Patch YouTube Music 8.44.54ΓÇô8.50.51 for crossfade."

@LisoUseInAIKyrios

LisoUseInAIKyrios commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

The crossfade warning is correct, it doesn't support 7.x or 9.x

@LisoUseInAIKyrios

LisoUseInAIKyrios commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Calling activity.finish() breaks cold launching the app if the start page is search.

@ILoveOpenSourceApplications ILoveOpenSourceApplications marked this pull request as draft April 24, 2026 15:33
@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the dev branch 6 times, most recently from e42f88a to 23f0c9f Compare April 27, 2026 10:55
@ILoveOpenSourceApplications ILoveOpenSourceApplications removed a link to an issue May 2, 2026
bug(YouTube Music): Setting start page to Charts while navigation bar is hidden, makes going to the settings impossible #1001
Closed
2 tasks
@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the dev branch 5 times, most recently from f0be5b8 to a2c0681 Compare May 14, 2026 06:39
@ILoveOpenSourceApplications
Merge branch 'dev' into fix/change-start-page
998e172 
# Conflicts:
#	patches/src/main/resources/addresources/values/youtube/strings.xml
@ILoveOpenSourceApplications
fix: Looping and exit app
a17a557
@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title fix(YouTube Music - Change start page): Route back button to Home when start page is overridden fix(Change start page): Route back button to exit the app May 27, 2026
@0xrxL 0xrxL force-pushed the dev branch 2 times, most recently from 6d9ade1 to 3ebb5eb Compare May 28, 2026 01:19
@ILoveOpenSourceApplications
Merge branch 'dev' into fix/change-start-page
ec51efc 
# Conflicts:
#	patches/src/main/kotlin/app/morphe/patches/youtube/layout/startpage/ChangeStartPagePatch.kt
@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the dev branch 5 times, most recently from 16896e1 to 93f3acd Compare June 11, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ILoveOpenSourceApplications @LisoUseInAIKyrios
⚡