🐛 Inject IMudMarkdownMemoryCache into MudMarkdownValueProvider#313
Merged
Conversation
MihailsKuzmins
requested changes
May 19, 2025
Member
There was a problem hiding this comment.
@MattParkerDev thanks. It looks like bUnit also registers an IMemoryCache, therefore, unit tests have not been able to catch this error and IMemoryCache was successfully injected into MudMarkdownValueProvider.
Therefore, could you please add a new unit test to prevent this error from happening in MudBlazor.Markdown.Tests?
Utils/ServiceCollectionExTests/AddMudMarkdownServicesShould.cs
※ please use tabs for indentation.
namespace MudBlazor.Markdown.Tests.Utils.ServiceCollectionExTests;
public sealed class AddMudMarkdownServicesShould
{
[Fact]
public void RegisterServices()
{
using var serviceProvider = new ServiceCollection()
.AddMudMarkdownServices()
.BuildServiceProvider();
serviceProvider.GetRequiredService<IMudMarkdownMemoryCache>()
.Should()
.BeOfType<MudMarkdownMemoryCache>();
serviceProvider.GetService<IMemoryCache>()
.Should()
.BeNull();
serviceProvider.GetRequiredService<IMudMarkdownThemeService>()
.Should()
.BeOfType<MudMarkdownThemeService>();
serviceProvider.GetRequiredService<IMudMarkdownValueProvider>()
.Should()
.BeOfType<MudMarkdownValueProvider>();
}
}
Contributor
Author
|
@MihailsKuzmins test added :) |
MihailsKuzmins
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #311
Tests pass, I haven't tested any further than that.