[STREAM-850] - Suppressing benign error so it does not show up on UI and cause confusion#940
[STREAM-850] - Suppressing benign error so it does not show up on UI and cause confusion#940maxwellmooney13 merged 3 commits intodevelopfrom
Conversation
…to consumer for specific error
maxwellmooney13
requested review from
hjon,
patrickfeeney03 and
zservies
as code owners
| callState: ICallStateFromParticipant | ||
| ): void { | ||
| if (callState.errorInfo) { | ||
| if (callState.errorInfo.code === 'error.ininedgecontrol.session.inactive' && callState.errorInfo.message.includes('is inactive for')) { |
There was a problem hiding this comment.
I'll be honest, I'm not entirely sure if this is the best check... I'm not 100% sure if just checking the code is sufficient so I added a check for the message too but I'm not sure if that is the best check either. I imagine we would get the translated version in the case of using a different language?
There was a problem hiding this comment.
I'm not sure these errors get translated, but I think I would lean towards just checking the code since that seems less likely to change over time.
There was a problem hiding this comment.
I don't think any of our error messaging is translated at this level but we shouldn't be checking for error text and should just check for the error code.
There was a problem hiding this comment.
My concern was just checking the error code would result in us swallowing non-benign errors that we actually wanted to show. Are we fine to just check the code without other errors being affected? I agree with both of you guys though.
There was a problem hiding this comment.
Do we know if this error code comes back for any other errors? I'm not sure why it would.
There was a problem hiding this comment.
I don't think we do know. I couldn't find an explanation of errors or anything like that. But if we wanna give it a try to just swallow this type of error code, I'm down to try.
There was a problem hiding this comment.
Probably worth asking the Edge guys.
| callState: ICallStateFromParticipant | ||
| ): void { | ||
| if (callState.errorInfo) { | ||
| if (callState.errorInfo.code === 'error.ininedgecontrol.session.inactive' && callState.errorInfo.message.includes('is inactive for')) { |
There was a problem hiding this comment.
I don't think any of our error messaging is translated at this level but we shouldn't be checking for error text and should just check for the error code.
|
|
||
| # [Unreleased](https://github.com/MyPureCloud/genesys-cloud-webrtc-sdk/compare/v11.3.0...HEAD) | ||
| # Changed | ||
| * [STREAM-850](https://inindca.atlassian.net/browse/STREAM-850) - Suppress benign error to not show on consumer UI |
There was a problem hiding this comment.
Can this be more descriptive? It just makes it easier to check the changelog and see what was changed if debugging an issue. Something like "Suppress error.ininedgecontrol.session.inactive errors to prevent UIs from presenting benign errors.
| callState: ICallStateFromParticipant | ||
| ): void { | ||
| if (callState.errorInfo) { | ||
| if (callState.errorInfo.code === 'error.ininedgecontrol.session.inactive') { |
There was a problem hiding this comment.
I'm not sure what we'd log, but I do wonder if its worth adding a debug log that says we're ignoring this benign error. Probably not a big deal to not add though.
3 participants
No description provided.