[STREAM-987] Memoize conversations so they don't change on every render#952
Merged
[STREAM-987] Memoize conversations so they don't change on every render#952
Conversation
…when nothing has changed
hjon
requested review from
maxwellmooney13,
patrickfeeney03 and
zservies
as code owners
bruegg
approved these changes
Nov 10, 2025
Collaborator
|
Yeah I think this fix is the right one. Something new and cool in the React compiler is the automatic detection of this stuff. So you don't need to manually do things like |
zservies
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't really know React, so I don't know if this is the best fix (or only fix for this situation), but this is the suggestion I got from the robots and it did seem to work correctly.
For context, it looks like the error started after this commit.