[STREAM-1099] - Emit participantsUpdate for JWT Video Guests#969
[STREAM-1099] - Emit participantsUpdate for JWT Video Guests#969patrickfeeney03 merged 14 commits intodevelopfrom
participantsUpdate for JWT Video Guests#969Conversation
patrickfeeney03
requested review from
hjon,
maxwellmooney13 and
zservies
as code owners
patrickfeeney03
changed the title
participantsUpdate for Video GuestsparticipantsUpdate for Video Guests
patrickfeeney03
changed the title
participantsUpdate for Video GuestsparticipantsUpdate for JWT Video Guests
| if (this._personDetails) { | ||
| if (this.isJwtAuth) { | ||
| const id = this._customerData.conversation?.id; | ||
| const userId = this._personDetails.id; |
There was a problem hiding this comment.
I might be overthinking it, but it might be safer to have something like:
const isGuest = !this._personDetails?.id;
There was a problem hiding this comment.
Also, is there ever a case where we'll have a userId with a JWT? Does that happen when using GCBA? I'm not sure off the top of my head.
There was a problem hiding this comment.
Also, is there ever a case where we'll have a userId with a JWT? Does that happen when using GCBA? I'm not sure off the top of my head.
I believe that GCBA participants do have a userId. I don't think the new code would affect that scenario though, since no subscription for JWT auth was being performed here before, and now it is but we make sure its an agent conference and that the participant is a guest.
There was a problem hiding this comment.
Yeah that makes sense since they aren't technically totally guest users.
hjon
left a comment
hjon
left a comment
There was a problem hiding this comment.
Don't forget to update the changelog. 🙂
# Conflicts: # changelog.md # package-lock.json
Make new code in `proxyStreamingClientEvents` safer and use existing helper functions.
4 participants
MERGE CHECKLIST
[STREAM-<ticket number>] - <description of changes>or[<issue number>] - <description of changes>.