STREAM-1034: jwt support for live-monitoring#971
Merged
Conversation
added 10 commits
January 6, 2026 14:20
…-sdk into STREAM-1034
…-sdk into STREAM-1034
AidanWZ
requested review from
hjon,
maxwellmooney13,
patrickfeeney03 and
zservies
as code owners
AidanWZ
commented
Jan 20, 2026
| } | ||
|
|
||
| // Auto-accept if current user is the target (fromUserId matches current user) | ||
| if (pendingSession.fromUserId === this.sdk._personDetails?.id) { |
Collaborator
Author
There was a problem hiding this comment.
- Media-controller:
LiveMonitorService.startMonitor()callsconferenceService.addParticipantForLiveMonitor()and passesrequest.getTargetUserId()as thetargetUserIdparameter for both the target and observer participants. - Media-controller:
ConferenceService.addParticipantForLiveMonitor()receives thistargetUserIdand passes it as theinitiatorUserId parameterto theaddParticipant()method: - Media-controller:
ConferenceService.addParticipant()receives theinitiatorUserIdand passes it tosendProposeStanza(). ConferenceService.sendProposeStanza()creates the Propose object and passesinitiatorUserIdwhich becomes thefromUserIdfield in the pending session
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
|
|
||
| mockSdk._config.autoAcceptPendingLiveScreenMonitoringRequests = false; | ||
| await handler.handlePropose({} as any); | ||
| const pendingSession = { fromUserId: 'user123' } as any; |
There was a problem hiding this comment.
Codacy has a fix for the issue: Unexpected any. Specify a different type.
Suggested change
| const pendingSession = { fromUserId: 'user123' } as any; | |
| const pendingSession = { fromUserId: 'user123' } as unknown; |
| const superSpy = jest.spyOn(BaseSessionHandler.prototype, 'handlePropose').mockResolvedValue(null); | ||
|
|
||
| mockSdk._config.autoAcceptPendingLiveScreenMonitoringRequests = false; | ||
| const pendingSession = { fromUserId: 'different-user' } as any; |
There was a problem hiding this comment.
Codacy has a fix for the issue: Unexpected any. Specify a different type.
Suggested change
| const pendingSession = { fromUserId: 'different-user' } as any; | |
| const pendingSession = { fromUserId: 'different-user' } as unknown; |
peterson-dc
approved these changes
Jan 21, 2026
zservies
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MERGE CHECKLIST
[STREAM-<ticket number>] - <description of changes>or[<issue number>] - <description of changes>.nexton npm.