[STREAM-1178] - Remove support for sending multiple tracks while screensharing. #975
Merged
[STREAM-1178] - Remove support for sending multiple tracks while screensharing. #975
Conversation
zservies
requested review from
hjon,
maxwellmooney13 and
patrickfeeney03
as code owners
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
| let displayMediaSpy: jest.SpyInstance<Promise<MediaStream>>; | ||
| let addMediaToSessionSpy: jest.SpyInstance<Promise<void>>; | ||
| let videoMuteSpy: jest.SpyInstance<Promise<void>>; | ||
| let addReplaceTrackToSession: jest.SpyInstance<Promise<any>>; |
There was a problem hiding this comment.
Codacy has a fix for the issue: Unexpected any. Specify a different type.
Suggested change
| let addReplaceTrackToSession: jest.SpyInstance<Promise<any>>; | |
| let addReplaceTrackToSession: jest.SpyInstance<Promise<unknown>>; |
AidanWZ
approved these changes
Feb 5, 2026
Collaborator
|
Is this effectively the revert of 825? EDIT: I have read the CHANGELOG |
maxwellmooney13
approved these changes
Feb 5, 2026
hjon
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MERGE CHECKLIST
[STREAM-<ticket number>] - <description of changes>or[<issue number>] - <description of changes>.