chore: additional confirmation of UserOperation (#54)

* chore: added additional confirmation of UO on RPC side before the processing

* chore: changeset

* chore: fix

Author: 0xdeval

.changeset/frank-dragons-poke.md

@@ -0,0 +1,15 @@
+---
+'@mycelium-sdk/core': major
+---
+
+## What was changed?
+
+- Added additional confirmation of a transaction for `send()` adn `sendBatch()` methods via RPC request using wait `waitForTransactionReceipt` method
+
+## Why was changed/added?
+
+- Bundler sometimes go ahead in state that RPC node. It cause an issue when RPC try to fetch a wallet balance, but got zero result as a node still work with an old block
+
+## How to use the change?
+
+- It will be used by default under the hood for `send()` and `sendBatch()` methods of the SDK

packages/sdk/src/test/mocks/ChainManagerMock.ts

@@ -11,6 +11,7 @@ export const createMockChainManager = (): ChainManager => {
   const mockPublicClient = {
     readContract: vi.fn(),
     getBalance: vi.fn(),
+    waitForTransactionReceipt: vi.fn(),
   } as unknown as PublicClient;
 
   const mockBundlerClient = {

packages/sdk/src/wallet/DefaultSmartWallet.spec.ts

@@ -172,12 +172,16 @@ describe('DefaultSmartWallet integration tests', () => {
       };
       vi.mocked(bundlerClient.estimateUserOperationGas).mockResolvedValue(mockGasEstimate);
       vi.mocked(bundlerClient.sendUserOperation).mockResolvedValue('0xTransactionHash');
-      // vi.mocked(bundlerClient.waitForUserOperationReceipt).mockResolvedValue({
-      //   receipt: {} as unknown as TransactionReceipt,
-      // });
+      vi.mocked(bundlerClient.waitForUserOperationReceipt).mockResolvedValue({
+        receipt: { transactionHash: '0xTransactionHash' },
+      });
 
       const result = await wallet.send(transactionData, chainId);
 
+      expect(
+        mockChainManager.getPublicClient(chainId).waitForTransactionReceipt,
+      ).toHaveBeenCalledWith({ hash: '0xTransactionHash' });
+
       expect(mockChainManager.getBundlerClient).toHaveBeenCalledWith(chainId, mockAccount);
       expect(bundlerClient.estimateUserOperationGas).toHaveBeenCalledWith({
         account: mockAccount,
@@ -264,9 +268,16 @@ describe('DefaultSmartWallet integration tests', () => {
       };
       vi.mocked(bundlerClient.estimateUserOperationGas).mockResolvedValue(mockGasEstimate);
       vi.mocked(bundlerClient.sendUserOperation).mockResolvedValue('0xTransactionHash');
+      vi.mocked(bundlerClient.waitForUserOperationReceipt).mockResolvedValue({
+        receipt: { transactionHash: '0xTransactionHash' },
+      });
 
       const result = await wallet.sendBatch(transactionData, chainId);
 
+      expect(
+        mockChainManager.getPublicClient(chainId).waitForTransactionReceipt,
+      ).toHaveBeenCalledWith({ hash: '0xTransactionHash' });
+
       expect(mockChainManager.getBundlerClient).toHaveBeenCalledWith(chainId, mockAccount);
       expect(bundlerClient.estimateUserOperationGas).toHaveBeenCalledWith({
         account: mockAccount,

packages/sdk/src/wallet/DefaultSmartWallet.ts

@@ -286,25 +286,31 @@ export class DefaultSmartWallet extends SmartWallet {
       }
 
       const bundlerClient = this.chainManager.getBundlerClient(chainId, account);
+      const publicClient = this.chainManager.getPublicClient(chainId);
 
       const gas = await bundlerClient.estimateUserOperationGas({
         account,
         calls: [transactionData],
       });
 
-      const hash = await bundlerClient.sendUserOperation({
+      const userOperationHash = await bundlerClient.sendUserOperation({
         account,
         calls: [transactionData],
         callGasLimit: this.bumpGasLimits(gas.callGasLimit),
         verificationGasLimit: this.bumpGasLimits(gas.verificationGasLimit),
         preVerificationGas: this.bumpGasLimits(gas.preVerificationGas),
       });
 
-      await bundlerClient.waitForUserOperationReceipt({
-        hash,
+      const userOperationReceipt = await bundlerClient.waitForUserOperationReceipt({
+        hash: userOperationHash,
       });
 
-      return hash;
+      // Extra check that RPC node has included the transaction in the block
+      await publicClient.waitForTransactionReceipt({
+        hash: userOperationReceipt.receipt.transactionHash,
+      });
+
+      return userOperationHash;
     } catch (error) {
       throw new Error(
         `Failed to send transaction: ${error instanceof Error ? error.message.toString().slice(0, 100) : 'Unknown error'}`,
@@ -346,25 +352,31 @@ export class DefaultSmartWallet extends SmartWallet {
       }
 
       const bundlerClient = this.chainManager.getBundlerClient(chainId, account);
+      const publicClient = this.chainManager.getPublicClient(chainId);
 
       const gas = await bundlerClient.estimateUserOperationGas({
         account,
         calls: transactionData,
       });
 
-      const hash = await bundlerClient.sendUserOperation({
+      const userOperationHash = await bundlerClient.sendUserOperation({
         account,
         calls: transactionData,
         callGasLimit: this.bumpGasLimits(gas.callGasLimit),
         verificationGasLimit: this.bumpGasLimits(gas.verificationGasLimit),
         preVerificationGas: this.bumpGasLimits(gas.preVerificationGas),
       });
 
-      await bundlerClient.waitForUserOperationReceipt({
-        hash,
+      const userOperationReceipt = await bundlerClient.waitForUserOperationReceipt({
+        hash: userOperationHash,
+      });
+
+      // Extra check that RPC node has included the transaction in the block
+      await publicClient.waitForTransactionReceipt({
+        hash: userOperationReceipt.receipt.transactionHash,
       });
 
-      return hash;
+      return userOperationHash;
     } catch (error) {
       throw new Error(
         `Failed to send transaction: ${error instanceof Error ? error.message : 'Unknown error'}`,