chore: additional confirmation of UserOperation #54
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds additional confirmation that UserOperations and their underlying transactions are included in the blockchain before the send() and sendBatch() methods return. It addresses issue #53 by implementing a two-step verification process: first waiting for the UserOperation receipt from the bundler, then additionally confirming the transaction is included on-chain via the RPC node.
Changes:
- Added
publicClient.waitForTransactionReceipt()call after receiving UserOperation receipt in bothsend()andsendBatch()methods - Renamed variable from
hashtouserOperationHashfor clarity - Updated test mocks to include transaction hash in UserOperation receipt
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/sdk/src/wallet/DefaultSmartWallet.ts | Added RPC-level transaction confirmation after UserOperation receipt in send() and sendBatch() methods |
| packages/sdk/src/wallet/DefaultSmartWallet.spec.ts | Updated test mocks to provide transaction hash in UserOperation receipt for both send() and sendBatch() tests |
| packages/sdk/src/test/mocks/ChainManagerMock.ts | Added waitForTransactionReceipt method to mock publicClient |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added additional confirmation of UO on RPC side before the processing
Resolve: #53