Fix gas reserve validation for high-decimal tokens in withdraw operations#52
Closed
Copilot wants to merge 3 commits intochore/paymaster-support-fixfrom
Closed
Fix gas reserve validation for high-decimal tokens in withdraw operations#52Copilot wants to merge 3 commits intochore/paymaster-support-fixfrom
Copilot wants to merge 3 commits intochore/paymaster-support-fixfrom
Conversation
3 tasks
…h-decimal tokens Co-authored-by: 0xdeval <26190360+0xdeval@users.noreply.github.com>
Co-authored-by: 0xdeval <26190360+0xdeval@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix feedback on paymaster support for protocols
Fix gas reserve validation for high-decimal tokens in withdraw operations
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the issue?
The withdraw validation in
validateGasReserve()was ineffective for high-decimal tokens. WhenoperationAmountis undefined (withdraw all scenario), the validation checkedbalance < gasReservewheregasReserve = max(balance * 1%, 1n). This made the check mathematically impossible to fail for any non-zero balance, allowing withdrawals that would leave insufficient tokens for gas payment.What was fixed?
Gas reserve calculation for high-decimal tokens:
calculateGasReserve()to returnmax(percentageReserve, fixedMinimum)for tokens with >6 decimalsfixedMinimumusesparseUnits(GAS_RESERVE_MINIMUM, decimals)(currently 0.01 tokens)TypeScript signature fix:
withdraw()signature fromamount?: stringtoamount: string | undefinedBefore:
After:
Related issues
Addresses feedback from #49
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.