Skip to content

Avoid aggressively trimming white space in text boxes in configure-beta #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ac-61 merged 1 commit into from
Feb 28, 2025
Merged

Avoid aggressively trimming white space in text boxes in configure-beta #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions configure/src/core/Maker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,9 @@ const getComponent = (
}}
value={value != null ? value : getIn(directConf, com.field, "")}
onChange={(e) => {
updateConfiguration(forceField || com.field, e.target.value, layer);
}}
onBlur={(e) => {
let v = e.target.value;
// remove surrounding whitespace, " hi " -> "hi"
if (typeof v === "string") v = v.trim();
Expand All @@ -280,6 +283,39 @@ const getComponent = (
)}
</div>
);
case "textnotrim":
inner = (
<TextField
className={c.text}
label={com.name}
variant="filled"
size="small"
inputProps={{
autoComplete: "off",
}}
value={value != null ? value : getIn(directConf, com.field, "")}
onChange={(e) => {
updateConfiguration(forceField || com.field, e.target.value, layer);
}}
/>
);
return (
<div>
{inlineHelp ? (
<>
{inner}
<div
className={c.subtitle2}
dangerouslySetInnerHTML={{ __html: com.description || "" }}
></div>
</>
) : (
<Tooltip title={com.description || ""} placement="top" arrow>
{inner}
</Tooltip>
)}
</div>
);
case "button":
inner = (
<Button
Expand Down
2 changes: 1 addition & 1 deletion configure/src/metaconfigs/layer-data-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"field": "name",
"name": "Layer Name",
"description": "",
"type": "text",
"type": "textnotrim",
"width": 8
},
{
Expand Down
2 changes: 1 addition & 1 deletion configure/src/metaconfigs/layer-header-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"field": "name",
"name": "Layer Name",
"description": "",
"type": "text",
"type": "textnotrim",
"width": 8
}
]
Expand Down
2 changes: 1 addition & 1 deletion configure/src/metaconfigs/layer-model-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"field": "name",
"name": "Layer Name",
"description": "A display name for the layer.",
"type": "text",
"type": "textnotrim",
"width": 6
},
{
Expand Down
2 changes: 1 addition & 1 deletion configure/src/metaconfigs/layer-query-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"field": "name",
"name": "Layer Name",
"description": "A display name for the layer.",
"type": "text",
"type": "textnotrim",
"width": 6
},
{
Expand Down
4 changes: 2 additions & 2 deletions configure/src/metaconfigs/layer-tile-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"field": "name",
"name": "Layer Name",
"description": "",
"type": "text",
"type": "textnotrim",
"width": 4
},
{
Expand Down Expand Up @@ -201,7 +201,7 @@
"field": "cogUnits",
"name": "Units",
"description": "Units string by which to suffix values. For instance if the units are meters, use 'm' so that values are displayed as '100m'.",
"type": "text",
"type": "textnotrim",
"width": 2
},
{
Expand Down
2 changes: 1 addition & 1 deletion configure/src/metaconfigs/layer-vector-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"field": "name",
"name": "Layer Name",
"description": "A display name for the layer.",
"type": "text",
"type": "textnotrim",
"width": 6
},
{
Expand Down
2 changes: 1 addition & 1 deletion configure/src/metaconfigs/layer-vectortile-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"field": "name",
"name": "Layer Name",
"description": "A display name for the layer.",
"type": "text",
"type": "textnotrim",
"width": 6
},
{
Expand Down
2 changes: 1 addition & 1 deletion configure/src/metaconfigs/layer-velocity-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"field": "name",
"name": "Layer Name",
"description": "A display name for the layer.",
"type": "text",
"type": "textnotrim",
"width": 6
},
{
Expand Down
⚡