Skip to content

Fix symlink bug#638

Merged
ac-61 merged 3 commits intodevelopmentfrom
ac-fix-symlink
Mar 4, 2025
Merged

Fix symlink bug#638
ac-61 merged 3 commits intodevelopmentfrom
ac-fix-symlink

Conversation

@ac-61
Copy link
Copy Markdown
Contributor

@ac-61 ac-61 commented Mar 4, 2025

There was a slightly weird commit in #636, where a file was still marked as a symlink, despite not being a symlink.

Current development branch:
Screenshot 2025-03-04 at 2 04 51 PM

This pull request:
Screenshot 2025-03-04 at 2 04 57 PM

@ac-61 ac-61 marked this pull request as ready for review March 4, 2025 21:58
@ac-61 ac-61 requested a review from tariqksoliman March 4, 2025 22:05
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 4, 2025

Copy link
Copy Markdown
Member

@tariqksoliman tariqksoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay. My commit to change that was bad then. Thanks for catching this. If the docker build and push succeeds again, feel free to merge.

@ac-61 ac-61 merged commit e3da8a3 into development Mar 4, 2025
2 checks passed
@ac-61 ac-61 deleted the ac-fix-symlink branch March 4, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants