Skip to content

initial add of STAC support#669

Merged
flynnplatt merged 12 commits intoNASA-AMMOS:developmentfrom
flynnplatt:improve_stac_geojson
Apr 22, 2025
Merged

initial add of STAC support#669
flynnplatt merged 12 commits intoNASA-AMMOS:developmentfrom
flynnplatt:improve_stac_geojson

Conversation

@flynnplatt
Copy link
Copy Markdown
Contributor

@flynnplatt flynnplatt commented Apr 2, 2025

Purpose

  • Adds support for STAC Catalog/Collection/Item GeoJSON

Proposed Changes

  • [ADD] New vector layer prefix: stac, stac-catalog, stac-collection, stac-item
  • [CHANGE] Layer config ingestion to pre-process a STAC catalog/collection/item into header/vector layers
  • [ADD] Automatic parsing of STAC assets for download links

@flynnplatt flynnplatt marked this pull request as ready for review April 16, 2025 01:01
@flynnplatt
Copy link
Copy Markdown
Contributor Author

@tariqksoliman We had previously discussed using this PR as an opportunity to add a dropdown to the Vector layer config that would perform the duties of the URL prefix, however I couldn't see a clean way to implement that without fully deprecating the URL prefix and that seemed like a bigger change than necessary at this point.

@tariqksoliman
Copy link
Copy Markdown
Member

@flynnplatt Okay, no worries and no need to implement it in this PR then.

Copy link
Copy Markdown
Member

@tariqksoliman tariqksoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the following vector layer URLs:

Comment thread src/essence/Basics/Layers_/Layers_.js Outdated
Copy link
Copy Markdown
Member

@tariqksoliman tariqksoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@flynnplatt
Copy link
Copy Markdown
Contributor Author

@tariqksoliman sorry for the re-review request but I ended up changing the implementation of fetching through a STAC tree to enable parallel fetches but that meant that I had to make a string of functions async. I think I did it right but I'm not sure if you have a good regression test to double-check that I didn't introduce some bug in the initial load.

The change I made makes using stac:https://cmr.earthdata.nasa.gov/stac/ORNL_CLOUD much faster to load

Copy link
Copy Markdown
Member

@tariqksoliman tariqksoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and don't see any issue with parseConfig being await/asynced

Thanks!

@flynnplatt flynnplatt merged commit 33a4022 into NASA-AMMOS:development Apr 22, 2025
0 of 2 checks passed
@flynnplatt flynnplatt deleted the improve_stac_geojson branch April 22, 2025 16:29
flynnplatt added a commit that referenced this pull request Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants