Skip to content

Actions Page Rework + Versioning + Archiving#1892

Merged
dandelany merged 39 commits intodevelopfrom
feat/actions-page-rework
Apr 14, 2026
Merged

Actions Page Rework + Versioning + Archiving#1892
dandelany merged 39 commits intodevelopfrom
feat/actions-page-rework

Conversation

@AaronPlave
Copy link
Copy Markdown
Contributor

@AaronPlave AaronPlave commented Mar 5, 2026

___REQUIRES_AERIE_PR___="1803"

Corresponding backend branch NASA-AMMOS/plandev#1803. Closes #1778

This PR moves the actions page into the workspace and introduces action+action definition versioning and archiving.

Workflows to test:

  • Uploading multiple versions of an action and making sure that only the newest versions are used when running the action
  • Archiving action versions and making sure that archived versions are not runnable (not even from re-run on action runs that used archived versions)
  • Upload action versions with different settings keys and make sure that unused settings keys are deleted from the action definition settings object (check in hasura)
  • Run an older version of an action and make sure that as many relevant settings are automatically filled out
  • Make sure that only admins can create, update, and archive actions and action versions

TODO:

  • A bit more UI cleanup and formatting
  • Fix/update e2e tests

@AaronPlave AaronPlave changed the title Feat/actions page rework WIP Actions Page Rework + Versioning + Archiving Mar 5, 2026
@AaronPlave AaronPlave marked this pull request as ready for review March 16, 2026 23:27
@AaronPlave AaronPlave requested a review from a team as a code owner March 16, 2026 23:27
@AaronPlave AaronPlave changed the title WIP Actions Page Rework + Versioning + Archiving Actions Page Rework + Versioning + Archiving Mar 16, 2026
@AaronPlave AaronPlave force-pushed the feat/actions-page-rework branch from c62768f to be26563 Compare March 17, 2026 19:00
Copy link
Copy Markdown
Collaborator

@dandelany dandelany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI notes from testing with @AaronPlave today:

  • The action run logs have some weird formatting/collapse behavior if you log a line that contains BOTH text and a JSON object. Eg. logging {a: b, ...} on its own looks fine, but if you log myObject is {a: b, ...big nested object} the logs will have some funky formatting with a timestamp inserted halfway through:
Image
  • General UI thought was that the action run results page feels "too application-y" and "not enough like a report". We discussed combining things on to one report-style page, with sections in the following order: Errors, Results, Logs, Parameters (leaving off any that don't apply). I'll run this by @nat-sims before we totally commit to it.

@duranb duranb temporarily deployed to test-workflow April 8, 2026 18:55 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow April 8, 2026 18:56 — with GitHub Actions Inactive
Copy link
Copy Markdown
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great!

… from action logs, show preview of JSOn objects in first line
Copy link
Copy Markdown
Collaborator

@dandelany dandelany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All known issues have been resolved - made a few updates to how log messages are handled from action runs & tested with @duranb - this should be ready to go when tests pass

@dandelany dandelany merged commit 2632b0f into develop Apr 14, 2026
5 checks passed
@dandelany dandelany deleted the feat/actions-page-rework branch April 14, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Way to delete and update Actions

3 participants