Skip to content

Add Deliveries to Database#1755

Draft
JosephVolosin wants to merge 1 commit intodevelopfrom
feature/deliveries
Draft

Add Deliveries to Database#1755
JosephVolosin wants to merge 1 commit intodevelopfrom
feature/deliveries

Conversation

@JosephVolosin
Copy link
Copy Markdown
Contributor

  • Tickets addressed: Related Pitch
  • Review: By commit
  • Merge strategy: Squash and merge

Description

This pull-request implements the back-end required for Deliveries.

Deliveries allow users to define a target (i.e., the target system) and package files from a sequence workspace to be 'delivered' to that target, including running any actions required prior to delivery. See pitch linked at the top of the description for more information.

The diagram below is an ERD representation of the tables being created.
DeliveryERD

Verification

Tests TODO

Documentation

Documentation TODO

Future work

TODO

@Mythicaeda
Copy link
Copy Markdown
Contributor

Question: is Aerie expected to do any delivery on its own? If not, why did you choose to use DB tables instead of, for example, tagging the relevant workspace files with a Delivered: Example tag or adding a delivered field to the file's metadata?

I'm mainly asking this because workspace files aren't tracked within the DB at all, making these DB filename references fairly weak links subject to breaking upon the file being moved or deleted. Related, filename is not a sufficient identifier, a file is found via it's workspace_id and its filepath within the workspace.

@JosephVolosin
Copy link
Copy Markdown
Contributor Author

Question: is Aerie expected to do any delivery on its own? If not, why did you choose to use DB tables instead of, for example, tagging the relevant workspace files with a Delivered: Example tag or adding a delivered field to the file's metadata?

I'm mainly asking this because workspace files aren't tracked within the DB at all, making these DB filename references fairly weak links subject to breaking upon the file being moved or deleted. Related, filename is not a sufficient identifier, a file is found via it's workspace_id and its filepath within the workspace.

Thats a great point re-utilizing tags/metadata, I'm not very familiar with either but @dandelany do you see any potential issues with either of those routes instead of database updates based on where our design is now? Would immediately solve the biggest problem like Theresa mentioned of not having a solid link since files are not tracked in the database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants