Correctly mask area for use in hypoxic area calculation#278
Merged
Conversation
uwagura
approved these changes
Jun 9, 2026
uwagura
left a comment
uwagura
left a comment
Collaborator
There was a problem hiding this comment.
I had some difficulty running this on analysis, mostly due to the size of the data and perhaps because of some dmget issues, but I was eventually able to run it by extracting a few days worth of daily data and running on that rather than the whole thing. We may want to explore ways of improving some of the diagnostics that use large, daily datasets in future, but that can be for a later PR. This one is good to go for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in the hypoxic area diagnostic: instead of the cell area being masked to only hypoxic conditions and summed, oxygen was masked to hypoxic conditions, multiplied by area, and then summed. Fortunately, because the oxygen was masked to where it was < 2, this had a fairly minor impact on the diagnostic result. Nevertheless, this PR fixes the bug and correctly calculates the area where oxygen is < 2 mg/l.