Feature/general indices gatscat#1832
Merged
vithikashah001 merged 10 commits intoNOAA-GFDL:mainfrom Apr 22, 2026
Merged
Conversation
… that specify canonical dim order when dim_order is not present.
…appers that specify canonical dim order when dim_order is not present.
uramirez8707
approved these changes
Apr 22, 2026
vithikashah001
approved these changes
Apr 22, 2026
Contributor
|
The new test seems to fail on C5 with ifx 2025.2.1. I have the following flags enabled: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for mpp_pelist_scatter and mpp_pelist_gather with generalized indices (dim_order), including correct handling of non-canonical storage layouts, along with a corresponding unit test.
This change ensures that scatter and gather operations work correctly when array data is stored in a layout that does not follow the canonical (i, j, k) ordering. Data movement remains consistent across MPI ranks regardless of how dimensions are permuted in memory.
A new test (test_mpp_pelist_gatscat_gen_ind) is introduced to validate pelist scatter/gather behavior across multiple permutations of storage layout.
How Has This Been Tested?
amdbox + intel + Autotools
Checklist:
make distcheckpasses