Initialize use_ice_shelf in ALE_regridding_and_remapping#872
Merged
Hallberg-NOAA merged 4 commits intoNOAA-GFDL:dev/gfdlfrom Apr 21, 2025
Merged
Initialize use_ice_shelf in ALE_regridding_and_remapping#872Hallberg-NOAA merged 4 commits intoNOAA-GFDL:dev/gfdlfrom
Hallberg-NOAA merged 4 commits intoNOAA-GFDL:dev/gfdlfrom
Conversation
adcroft
reviewed
Apr 2, 2025
Member
adcroft
left a comment
adcroft
left a comment
There was a problem hiding this comment.
Thank you - good catch. It looks like we lost the pathway to change use_ice_shelf at all, which might explain some recent problems we've been having with the ice-shelf!
|
The code to set |
Recovers the conditional code that sets use_ice_shelf in ALE_regridding_and_remapping()
Member
theresa-cordero
approved these changes
Apr 21, 2025
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/27194. |
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use_ice_shelfis used inALE_regridding_and_remappingwithout being defined and causes a model crash in debug mode.This PR initialize
use_ice_shelf = .false.