Change MOM_generic_tracer to a stub#884
Merged
Hallberg-NOAA merged 4 commits intoNOAA-GFDL:dev/gfdlfrom Jul 11, 2025
Merged
Conversation
Author
|
ocean_BGC PR 37 has been merged. |
theresa-cordero
commented
Jul 10, 2025
Hallberg-NOAA
approved these changes
Jul 10, 2025
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I have examined these changes, I think that we are ready to merge this revised commit into dev/gfdl.
This PR removes the content from the functions and routines in MOM_generic_tracer to turn it into a stub. In addition, the other modules in config_src/external/GFDL_ocean_BGC are removed since they are no longer called anywhere.
Remove unneeded use statements.
A fatal error has been added to register_MOM_generic_tracer which will occur if the stub version of MOM_generic_tracer has been compiled but use_generic_tracer is true.
Hallberg-NOAA
force-pushed
the
stub_MOM_gentrc
branch
from
0866b67 to
5573d89
Compare
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/28091. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recommend this PR not be merged until after ocean_BGC PR 37 is merged.
This PR is a follow up to PR #790
This PR is the final step in the transition to have the interface between MOM6 and generic tracers occur within the generic tracer code. This will allow each generic tracer package to specify the needed input from the MOM6 types and will not require a common interface across a diverse set of generic tracer packages.
This PR cleans up the
config_src/external/GFDL_ocean_BGCfolder by changingMOM_generic_tracer.F90into a stub. By removing the content from the functions and the routines inMOM_generic_tracer.F90, the other modulesFMS_coupler_util.F90,generic_tracer.F90andgeneric_tracer_utils.F90@yichengt900 @nikizadehgfdl