run backbone model only for prefill#100
Merged
maxjeblick merged 2 commits intoNVIDIA:mainfrom Jul 28, 2025
Merged
Conversation
Collaborator
Signed-off-by: giulio98 <corallo.giulio@yahoo.it>
Signed-off-by: giulio98 <corallo.giulio@yahoo.it>
Contributor
Author
Everything is good, however I noticed that results are not deterministic (even before this PR) w.r.t the leaderboard on HF. seed = 42
torch.backends.cudnn.deterministic = True
torch.backends.cudnn.benchmark = False
random.seed(seed)
np.random.seed(seed)
torch.manual_seed(seed)
torch.cuda.manual_seed_all(seed)in |
alessiodevoto
approved these changes
Jul 28, 2025
Collaborator
|
Hi @giulio98 thanks for spotting this! We'll change it in the next version of evaluate.py ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Fixes #91
Results Llama-3.1-8B-Instruct on RULER-4k
While the savings is modest for the experiment I did, they can become significant in scenarios involving large models or long context sequences.
Checklist
make test)make style, on errors try fix withmake format)git commit -smypress_press.pyis in thepressesdirectoryMyPressis in__init__.pyREADME.mdis updated with a 1 liner about the new press in the Available presses sectiondefault_presseslist intests/default_presses.py