Skip to content

Fix links in benchmarks directory#101

Merged
alessiodevoto merged 1 commit intomainfrom
fix-links
Jul 21, 2025
Merged

Fix links in benchmarks directory#101
alessiodevoto merged 1 commit intomainfrom
fix-links

Conversation

@alessiodevoto
Copy link
Copy Markdown
Collaborator

PR description

Quick PR to fix links for benchmarks

Checklist

  • Tests are working (make test)
  • Code is formatted correctly (make style, on errors try fix with make format)
  • Copyright header is included
  • All commits are signed-off using git commit -s
  • (new press) mypress_press.py is in the presses directory
  • (new press) MyPress is in __init__.py
  • (new press) README.md is updated with a 1 liner about the new press in the Available presses section
  • (new press) New press is in the default_presses list in tests/default_presses.py
  • (new press) A docstring is provided that follows the same structure as the existing ones

Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
@maxjeblick maxjeblick requested a review from Copilot July 18, 2025 22:39
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes broken relative links in the benchmarks directory README by correcting the path depth to properly reference evaluation assets and scripts.

  • Updates image links from ../evaluation/assets/ to ../../evaluation/assets/
  • Fixes reference link to calculation script from ../evaluation/loogle/ to ../../evaluation/loogle/

@maxjeblick maxjeblick self-requested a review July 18, 2025 22:40
Copy link
Copy Markdown
Collaborator

@maxjeblick maxjeblick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix!

@alessiodevoto alessiodevoto merged commit 3fac2a1 into main Jul 21, 2025
3 checks passed
@alessiodevoto alessiodevoto deleted the fix-links branch July 21, 2025 11:39
maxjeblick pushed a commit that referenced this pull request Aug 12, 2025
Signed-off-by: Max Jeblick <maximilianjeblick@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants