Skip to content

Transformers compatibility + evaluation#105

Merged
maxjeblick merged 8 commits intomainfrom
aledev/fix-eval
Jul 28, 2025
Merged

Transformers compatibility + evaluation#105
maxjeblick merged 8 commits intomainfrom
aledev/fix-eval

Conversation

@alessiodevoto
Copy link
Copy Markdown
Collaborator

PR description

  • Transformers released a new version which breaks some parts of the library, so in this PR we changed the dependency while we work on adjusting to the new version.
  • Updated evaluation to have a seed in the config.

Checklist

  • Tests are working (make test)
  • Code is formatted correctly (make style, on errors try fix with make format)
  • Copyright header is included
  • All commits are signed-off using git commit -s
  • (new press) mypress_press.py is in the presses directory
  • (new press) MyPress is in __init__.py
  • (new press) README.md is updated with a 1 liner about the new press in the Available presses section
  • (new press) New press is in the default_presses list in tests/default_presses.py
  • (new press) A docstring is provided that follows the same structure as the existing ones

Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
@maxjeblick maxjeblick self-requested a review July 28, 2025 09:36
Copy link
Copy Markdown
Collaborator

@maxjeblick maxjeblick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the changes, looks good!
I left some comments in the eval code

Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Copy link
Copy Markdown
Collaborator

@maxjeblick maxjeblick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@maxjeblick maxjeblick merged commit 52c761c into main Jul 28, 2025
3 checks passed
@maxjeblick maxjeblick deleted the aledev/fix-eval branch July 28, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants