Skip to content

Add PyramidKVPress#66

Merged
maxjeblick merged 3 commits intoNVIDIA:mainfrom
figuremout:pyramidkv
Apr 16, 2025
Merged

Add PyramidKVPress#66
maxjeblick merged 3 commits intoNVIDIA:mainfrom
figuremout:pyramidkv

Conversation

@figuremout
Copy link
Copy Markdown
Contributor

PR description

Add support for PyramidKVPress (#65) based on the original author's code. It maintains pyramid-like cache sizes, allocating more cache budget to lower layers and less to higher layers.

It performs slightly worse on the RULER 4k dataset than SnapKV.
2db20cfa-4d76-4e63-9b98-eb5a2ef1411c

Checklist

  • Tests are working (make test)
=============== 100 passed, 23 skipped, 2 warnings in 59.27s ================
  • Code is formatted correctly (make style, on errors try fix with make format)
Found 27 errors in 2 files (checked 42 source files)
make: *** [Makefile:28: style] Error 1

But none of them related to my PR.

  • Copyright header is included
  • All commits are signed-off using git commit -s
  • (new press) mypress_press.py is in the presses directory
  • (new press) MyPress is in __init__.py
  • (new press) README.md is updated with a 1 liner about the new press in the Available presses section
  • (new press) new press is in the default_presses list in tests/default_presses.py

Signed-off-by: figuremout <1344584929@qq.com>
@maxjeblick maxjeblick self-requested a review April 10, 2025 09:52
@figuremout figuremout marked this pull request as ready for review April 11, 2025 10:05
Signed-off-by: figuremout <1344584929@qq.com>
Copy link
Copy Markdown
Collaborator

@maxjeblick maxjeblick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PR for PyramidKVPress! I left a few comments in the code.
Feel free to comment with any follow-up questions/remarks.

Signed-off-by: figuremout <1344584929@qq.com>
Copy link
Copy Markdown
Collaborator

@maxjeblick maxjeblick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for adding PyramidKVPress!

@maxjeblick maxjeblick merged commit b701a31 into NVIDIA:main Apr 16, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants