Merged
Conversation
Signed-off-by: figuremout <1344584929@qq.com>
Signed-off-by: figuremout <1344584929@qq.com>
maxjeblick
requested changes
Apr 14, 2025
Collaborator
maxjeblick
left a comment
There was a problem hiding this comment.
Thanks a lot for your PR for PyramidKVPress! I left a few comments in the code.
Feel free to comment with any follow-up questions/remarks.
Signed-off-by: figuremout <1344584929@qq.com>
maxjeblick
approved these changes
Apr 16, 2025
Collaborator
maxjeblick
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot for adding PyramidKVPress!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Add support for PyramidKVPress (#65) based on the original author's code. It maintains pyramid-like cache sizes, allocating more cache budget to lower layers and less to higher layers.
It performs slightly worse on the RULER 4k dataset than SnapKV.

Checklist
But none of them related to my PR.
git commit -smypress_press.pyis in thepressesdirectoryMyPressis in__init__.pyREADME.mdis updated with a 1 liner about the new press in the Available presses sectiondefault_presseslist intests/default_presses.py