Skip to content

Refactored FinchPress#69

Merged
SimJeg merged 8 commits intomainfrom
simon/finch
Apr 17, 2025
Merged

Refactored FinchPress#69
SimJeg merged 8 commits intomainfrom
simon/finch

Conversation

@SimJeg
Copy link
Copy Markdown
Collaborator

@SimJeg SimJeg commented Apr 17, 2025

Refactoring of #64:

  • no major update for pipeline.py, everything is in the press itself
  • no chunked pre-filling

Xnhyacinth and others added 6 commits April 17, 2025 10:05
Signed-off-by: SimJeg <[email protected]>
Signed-off-by: SimJeg <[email protected]>
Signed-off-by: SimJeg <[email protected]>
Signed-off-by: SimJeg <[email protected]>
@SimJeg SimJeg mentioned this pull request Apr 17, 2025
5 tasks
Copy link
Copy Markdown
Collaborator

@maxjeblick maxjeblick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: giulio98 <[email protected]>
Co-authored-by: miriam-16 <[email protected]>
Co-authored-by: FaureElia <[email protected]>
Signed-off-by: SimJeg <[email protected]>
@SimJeg
Copy link
Copy Markdown
Collaborator Author

SimJeg commented Apr 17, 2025

@giulio98 if you have no comments we'll merge this branch today

Signed-off-by: SimJeg <[email protected]>
@giulio98
Copy link
Copy Markdown
Contributor

LGTM

@SimJeg SimJeg merged commit ef5179d into main Apr 17, 2025
3 checks passed
@SimJeg SimJeg deleted the simon/finch branch April 17, 2025 14:01
@SimJeg SimJeg mentioned this pull request Apr 17, 2025
@SimJeg
Copy link
Copy Markdown
Collaborator Author

SimJeg commented Apr 17, 2025

@giulio98 I think you don't appear in the contributors because the commits are squashed and the latest commit was not co-authored by everyone. Will try to fix this in a later release

maxjeblick pushed a commit that referenced this pull request Aug 12, 2025
Signed-off-by: Max Jeblick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants