Merged
Conversation
Signed-off-by: Kyle Liang <liangmanlai@gmail.com>
Signed-off-by: Kyle Liang <liangmanlai@gmail.com>
Signed-off-by: Kyle Liang <liangmanlai@gmail.com>
Signed-off-by: Kyle Liang <liangmanlai@gmail.com>
alessiodevoto
requested changes
Jun 5, 2025
Collaborator
|
Hi and thanks for opening this PR!
|
Contributor
Author
|
Thanks for the comments. I will fix them. |
alessiodevoto
requested changes
Jun 6, 2025
Collaborator
alessiodevoto
left a comment
There was a problem hiding this comment.
Some additional minor changes
Collaborator
|
@JoelSeniorLiang also, because we updated the main, don't forget to merge it into your branch, thanks 🙂 |
Signed-off-by: Kyle Liang <liangmanlai@gmail.com>
Contributor
Author
|
fixs are commit |
Signed-off-by: Kyle Liang <liangmanlai@gmail.com>
Signed-off-by: Kyle Liang <liangmanlai@gmail.com>
JoelSeniorLiang
commented
Jun 10, 2025
Contributor
Author
JoelSeniorLiang
left a comment
There was a problem hiding this comment.
fix all the required changes.
alessiodevoto
approved these changes
Jun 10, 2025
maxjeblick
pushed a commit
that referenced
this pull request
Aug 12, 2025
Signed-off-by: Max Jeblick <maximilianjeblick@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#75 PR description
Description of your PR. Fixes # (issue) (if applicable)
Checklist
git commit -smypress_press.pyis in thepressesdirectoryMyPressis in__init__.pyREADME.mdis updated with a 1 liner about the new press in the Available presses sectiondefault_presseslist intests/default_presses.py