Merged
Conversation
alessiodevoto
force-pushed
the
feat-qwen3-gemma3
branch
2 times, most recently
from
9ab6c0f to
e9d2ad9
Compare
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
alessiodevoto
force-pushed
the
feat-qwen3-gemma3
branch
from
e9d2ad9 to
ec53981
Compare
SimJeg
reviewed
Jun 12, 2025
SimJeg
reviewed
Jun 12, 2025
SimJeg
reviewed
Jun 12, 2025
SimJeg
reviewed
Jun 12, 2025
SimJeg
reviewed
Jun 12, 2025
Collaborator
|
Also @alessiodevoto please check if issue #80 involves other changes in this PR |
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
Collaborator
Author
Signed-off-by: alessiodevoto <devoto.alessio@gmail.com>
SimJeg
approved these changes
Jun 16, 2025
maxjeblick
pushed a commit
that referenced
this pull request
Aug 12, 2025
Signed-off-by: Max Jeblick <maximilianjeblick@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #76 to support the QK normalization used in Gemma3 and Qwen3 (+ updates library version).