Javanica HystrixRequestCacheManager should use the concurrency strategy from HystrixPlugins#1108
Merged
mattrjacobs merged 1 commit intoNetflix:1.4.xfrom Feb 29, 2016
jhinch:javanica-plugins-concurrency-strategy
Merged
Javanica HystrixRequestCacheManager should use the concurrency strategy from HystrixPlugins#1108mattrjacobs merged 1 commit intoNetflix:1.4.xfrom jhinch:javanica-plugins-concurrency-strategy
mattrjacobs merged 1 commit intoNetflix:1.4.xfrom
jhinch:javanica-plugins-concurrency-strategy
Conversation
from HystrixPlugins, not the default one directly
|
NetflixOSS » Hystrix » Hystrix-pull-requests #361 SUCCESS |
Contributor
|
Thanks for the submission @jhinch . Will do a pass over changes to master, see if anything else should get backported to 1.4.x, and do a release later today |
mattrjacobs
added a commit
that referenced
this pull request
Feb 29, 2016
…ategy Javanica HystrixRequestCacheManager should use the concurrency strategy from HystrixPlugins
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can result in unexpected results if the concurrency strategy has overridden getRequestVariable. In my case this resulted in a NPE when clearing the cache entry