Support unsubscription of HystrixCommands#1204
Merged
mattrjacobs merged 5 commits intoNetflix:masterfrom May 13, 2016
Merged
Conversation
Contributor
Author
|
👍 |
added 2 commits
May 13, 2016 12:29
…in the request-cache and the loser needs to get cleaned up (unsubscribed)
Contributor
Author
|
Thanks @stevegury. Just modified the state in |
|
👍 |
…race request-cache insert
This was referenced May 13, 2016
|
I think the implementation of com.netflix.hystrix.HystrixCommand.queue() is still not compliant with Future.cancel(boolean) as it does not seem to interrupt the execution thread. |
Contributor
Author
|
I just created a new issue to track making this work properly: #1268 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a large reorganization of Hystrix internals to support unsubscription.
The changes are:
Observable.createI've added a number of tests to check unsubscription. Outstanding work: