Fixed incorrect thread pool rate calculations in dashboard#139
Merged
opuneet merged 1 commit intoNetflix:masterfrom Jun 7, 2013
Merged
Fixed incorrect thread pool rate calculations in dashboard#139opuneet merged 1 commit intoNetflix:masterfrom
opuneet merged 1 commit intoNetflix:masterfrom
Conversation
…account the rolling counter window size, thus giving a ten times too large value
|
Hystrix-pull-requests #14 FAILURE |
opuneet
added a commit
that referenced
this pull request
Jun 7, 2013
Fixed incorrect thread pool rate calculations in dashboard
Contributor
|
This looks great. Just validated this and I'm pushing this fix to our own internal dashboard. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed incorrect thread pool rate calculations that did not take into account the rolling counter window size, thus giving a ten times too large value.
Also removed two data elements, propertyValue_corePoolSize and rollingThreadExecutions. They are not created in hystrix-metrics-event-stream and are not used as far as I can see.