Bugfix to HystrixBadRequestException handling#183
Merged
benjchristensen merged 1 commit intoNetflix:masterfrom Sep 27, 2013
Merged
Bugfix to HystrixBadRequestException handling#183benjchristensen merged 1 commit intoNetflix:masterfrom
benjchristensen merged 1 commit intoNetflix:masterfrom
Conversation
…getting generated when HystrixBadRequestExceptions got thrown
|
Hystrix-pull-requests #49 ABORTED |
benjchristensen
added a commit
that referenced
this pull request
Sep 27, 2013
Bugfix to HystrixBadRequestException handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logs were spuriously getting generated by
HystrixBadRequestExceptions.Only functional diff is that the
log.warnis now not called unless theHystrixCommandExecutionHook.onRunErrorinvocation throws an Exception. I didn't add a mockLogger for testing purposes, but checked that theHystrixBadRequestExceptioncase was completely handled already - so no regressions here.Also, changed the log message to match the
HystrixCommandExecutionHookmethod name :onRunError