deploying hystrix dashboard on tomcat, SLF4J complains about a missing implementation

[ahus1]

this change fixes it by exchanging the API for the implemenation (like it has been before the upgrade of slf4j 1.7.0), see f29321c

[cloudbees-pull-request-builder]

Hystrix-pull-requests #64 FAILURE
Looks like there's a problem with this pull request

[ahus1]

One test fails on cloudbees, a different test fails on the command line, but not in the IDE. Looks a bit unstable here :-( it shouldn't be fixed in this change, I'll look at it another time.

[benjchristensen]

The point of SL4J is to only have the API. See here: http://www.slf4j.org

Note that SLF4J-enabling your library implies the addition of only a single mandatory dependency, namely slf4j-api.jar. If no binding is found on the class path, then SLF4J will default to a no-operation implementation.

[ahus1]

Hello Ben,

I know that using slf4j-api is the thing to use in libraries.

But hystrix-dashboard is a web application archive (WAR), that should include an implementation (like it includes a log4j.properties as well).

Otherwise it will not do any logging at all.

Please consider re-opening the pull request and merge the changes.

Thanks, Alexander.

[benjchristensen]

Ah okay, I see what you mean.

[cloudbees-pull-request-builder]

Hystrix-pull-requests #70 SUCCESS
This pull request looks good