Remove synchronous timeout#579
Merged
mattrjacobs merged 2 commits intoNetflix:masterfrom Jan 28, 2015
Merged
Conversation
added 2 commits
January 27, 2015 21:01
Conflicts: hystrix-core/src/main/java/com/netflix/hystrix/AbstractCommand.java
|
Hystrix-pull-requests #250 FAILURE |
|
NetflixOSS » Hystrix » Hystrix-pull-requests #11 SUCCESS |
mattrjacobs
added a commit
that referenced
this pull request
Jan 28, 2015
…7-rebase Remove synchronous timeout
This was referenced Jan 28, 2015
This was referenced Feb 5, 2015
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the synchronous timeout path entirely and relies solely on async timeouts coming from the HystrixTimer thread. Previously, calling
HystrixCommand.execute()or.queue()would trigger the synchronous timeout.Internal performance tests have indicated that performance is generally unchanged with this PR. I've also created a issue (#578) to track getting performance tests included as part of this project.
The benefits of this change are: