Remove commons-collections dependency. (Backport of #899)#900
Merged
mattrjacobs merged 1 commit intoNetflix:1.4.xfrom Sep 17, 2015
Merged
Remove commons-collections dependency. (Backport of #899)#900mattrjacobs merged 1 commit intoNetflix:1.4.xfrom
mattrjacobs merged 1 commit intoNetflix:1.4.xfrom
Conversation
This library was only used in two places: - HystrixPropertiesManager.java: A simple null check works in its place. - CacheInvocationContext.java: The field keyParameters will not be null so calling isEmpty directly will not result in a NullPointerException. This is one less dependency to manage and avoids bringing in a ~500k jar for null checks.
|
NetflixOSS » Hystrix » Hystrix-pull-requests #182 SUCCESS |
mattrjacobs
added a commit
that referenced
this pull request
Sep 17, 2015
Remove commons-collections dependency. (Backport of #899)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library was only used in two places:
calling isEmpty directly will not result in a NullPointerException.
This is one less dependency to manage and avoids bringing in a ~500k jar for
null checks.