Describe the bug
Please provide a clear and concise description of what the bug is.
- NorESM version: noresm_beta12a
- HPC platform: any
- Compiler (if applicable):any
- Compset (if applicable): any fates compset with drydep on
- Resolution (if applicable): any
- Error message (if applicable): None
To Reproduce
Steps to reproduce the behavior:
- Run with drydep and fates
Additional context
Fates SHOULD calculate Wesley season and read wesley vegetation index for all the patches. however, the iterator for bc_out was outside the patch loop, which lead to values actually applying on one vegetated patch (out of many) and incorretly. All other patches were getting basically bare ground. The only thing that was changing for them was snow/no-snow condition.
https://github.com/NorESMhub/fates/blob/ee7e56ef4bad0341acfdfb1f4fb447072661f79b/main/FatesInterfaceMod.F90#L2376-L2383
do s = 1,nsites
ifp=0
bc_out(s)%wesley_pft_label_pa(:)=8 !for no vegetation.
bc_out(s)%drydep_season_pa(:) = 3 ! bare
currentPatch => sites(s)%oldest_patch
ifp=ifp+1
do while(associated(currentPatch))
if(currentPatch%nocomp_pft_label>0)then Not sure, how bad setting bareground is for drydep velocities and what effect this has on climate + fixing this will definitely change it.
Describe the bug
Please provide a clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
Additional context
Fates SHOULD calculate Wesley season and read wesley vegetation index for all the patches. however, the iterator for
bc_outwas outside the patch loop, which lead to values actually applying on one vegetated patch (out of many) and incorretly. All other patches were getting basically bare ground. The only thing that was changing for them was snow/no-snow condition.https://github.com/NorESMhub/fates/blob/ee7e56ef4bad0341acfdfb1f4fb447072661f79b/main/FatesInterfaceMod.F90#L2376-L2383
Not sure, how bad setting bareground is for drydep velocities and what effect this has on climate + fixing this will definitely change it.