Megan fates

[rosiealice]

Description:

New Megan PR to update FATES to create megan PFTs. coordinated with CTSM side PR at
NorESMhub/CTSM#74

Collaborators:

Expectation of Answer Changes:

Checklist:

• My change requires a change to the documentation.
• I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
• I have read the CONTRIBUTING document.
• FATES PASS/FAIL regression tests were run
• If answers were expected to change, evaluation was performed and provided

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

[mvertens]

@rosiealice - I'd like to merge this at this point even though the check boxes have not been done. We need this for noresm2_5_alpha08 unless I point to my own fork for CTSM. Are you okay with merging this now?

[rosiealice]

Sounds great. Did you manage to run the tests or do you want to just merge it anyway?

I don't think it requires a change to the documentation yet as we do not have seperate NorESM-FATES documentation and this would thus perhaps need to be done when merging back into the main FATES repo.

[mvertens]

@rosiealice - I ran the new test suite I introduced. Out of 24 tests - 19 passed. The following 5 failed. The create_newcase are known failures since this requires numpy to be available on betzy as a module - and that is currently not working. I fixed the XML test - but have not rerun. This leaves 2 failed tests that I have not had a chance to look at yet.

FAIL ERS_D_Ld15.f45_f45_mg37.2000_DATM%GSWP3v1_CLM60%FATES-NOCOMP_SICE_SOCN_MOSART_SGLC_SWAV.betzy_intel.clm-FatesColdTwoStreamNoCompFixedBioGeo CREATE_NEWCASE
FAIL ERS_L761.ne30pg3_ne30pg3_mtn14.2000_DATM%GSWP3v1_CLM60%FATES-NOCOMP_SICE_SOCN_MOSART_SGLC_SWAV.betzy_intel.clm-FatesColdNoComp XML
FAIL ERS_Ld761.f45_f45_mg37.2000_DATM%GSWP3v1_CLM60%FATES-NOCOMP_SICE_SOCN_MOSART_SGLC_SWAV.betzy_intel.clm-FatesColdTwoStreamNoCompFixedBioGeo CREATE_NEWCASE
FAIL SMS_D.1x1_brazil.2000_DATM%GSWP3v1_CLM60%FATES-SP_SICE_SOCN_SROF_SGLC_SWAV.betzy_intel.clm-FatesColdDryDepSatPhen RUN time=40
FAIL SMS_D_Ld3.ne30pg3_ne30pg3_mtn14.2000_DATM%GSWP3v1_CLM60%FATES-SP_SICE_SOCN_SROF_SGLC_SWAV.betzy_intel.clm-FatesColdSatPhen_prescribed RUN time=52

In addition, I did run this code along with the updated ctsm PR in a debug tests for n1850 with fates-sp and it passed!