Dry deposition working with FATES-NOCOMP#11
Closed
rosiealice wants to merge 13 commits intoNorESMhub:noresmfrom
Closed
Dry deposition working with FATES-NOCOMP#11rosiealice wants to merge 13 commits intoNorESMhub:noresmfrom
rosiealice wants to merge 13 commits intoNorESMhub:noresmfrom
Conversation
|
@rosiealice - I think it would not be easier to make 2 PRs here.
|
Collaborator
Author
|
Yes, it would be good to bring noresm up to date with NGEET/ FATES main. For some reason I could not see the noresm branch this morning, but I do think it would be better if there was another PR before this one to update it. I can try and have a go... Note that the NorESMhub/CTSM tags we are using currently point to a NGEET/FATES tag and not here.. https://github.com/NorESMhub/NorESM/blob/noresm2_5_alpha06/Externals_CLM.cfg |
5 tasks
This was referenced Oct 25, 2024
Collaborator
Author
|
Replaced by #13 |
Collaborator
Author
|
closing this PR as it is redundant. |
rosiealice
pushed a commit
that referenced
this pull request
Mar 29, 2025
added parameters and merged up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the FATES-side changed for making FATES-NOCOMP mode work with dry deposition.
The noresm branch appears to be somewhat behind the FATES main, hence the large number of apparent differences.
This code runs in coupled mode and produces valid outputs. Analysis of the validity of their magnitudes is ongoing.
A follow-up PR will introduce the scientifically useful calculation of the seasons. This PR is just to make the code function at all.
Description:
Collaborators:
@mvdebolskiy
@mvertens
@maritsandstad
@kjetilaas
Expectation of Answer Changes:
Answers are expected to change, but only for the dry deposition fields. It is hard to assess the impact of these answer changes as these fields were not generated before and the model version that generates them did not function prior to this PR.
But nothing else should change except for the dry deposition fields.
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: