Update JSON product to use correct download PURL cl.md#2712
Closed
Update JSON product to use correct download PURL cl.md#2712
Conversation
This is, if I remember correctly the consequence of a design decision for the PURL system. While the PURL defined by ODK etc is http://purl.obolibrary.org/obo/cl.json, the PURL system only recognises a tiny number of defaults _above_ the ontology namespace (including cl.owl and cl.obo), but cl.json is not part of it. We could argue that we should also add cl.json to this list.
|
Thanks! I guess this could be merged just to have an immediate fix and then the general issues could be addressed on a separate PR. |
Contributor
Author
|
Apparently I was wrong: OBOFoundry/purl.obolibrary.org#1039 OOPS |
Contributor
Author
|
@bgyori the problems was generally fixed, CL was missing a declaration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2710
This is, if I remember correctly the consequence of a design decision for the PURL system.
While the PURL defined by ODK etc is http://purl.obolibrary.org/obo/cl.json, the PURL system only recognises a tiny number of defaults above the ontology namespace
http://purl.obolibrary.org/obo/cl/(including cl.owl and cl.obo), but cl.json is not part of it.We could argue that we should also add cl.json to this list.
For those with energy and a sense of beauty, the next steps from this would be:
http://purl.obolibrary.org/obo/cl.[a-z0-1]+) as valid PURL defaults, make issue here ORhttp://purl.obolibrary.org/obo/cl/cl.[a-z0-1]+syntax