Make sure CL's IRIs for imported files are resolvable.#1043
Merged
jamesaoverton merged 1 commit intoOBOFoundry:masterfrom May 16, 2025
Merged
Make sure CL's IRIs for imported files are resolvable.#1043jamesaoverton merged 1 commit intoOBOFoundry:masterfrom
jamesaoverton merged 1 commit intoOBOFoundry:masterfrom
Conversation
Add special cases in the CL configuration for the three types of IRIs that are used in OWL import declarations within the ontology's edit file (imports, components, and pattern-derived definitions). The corresponding files are not release artefacts, so if we redirect those IRIs using the default generic fall-through (which redirects to the download folder of the latest release) they will end in 404 errors. Instead, we redirect those IRIs to point to the master branch. See obophenotype/cell-ontology#3119.
jamesaoverton
approved these changes
May 16, 2025
Member
jamesaoverton
left a comment
jamesaoverton
left a comment
There was a problem hiding this comment.
Looks good. Ready for me to merge?
Contributor
Author
|
Yes please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds special rules in the CL configuration for the three types of IRIs that are used in OWL import declarations within the ontology's edit file (imports, components, and pattern-derived definitions). The corresponding files are not release artefacts, so if we redirect those IRIs using the default generic fall-through (which redirects to the download folder of the latest release) they will end in 404 errors. Instead, we redirect those IRIs to point to the master branch.
See obophenotype/cell-ontology#3119.