Skip to content

[18.0][IMP] apriori: sale_commission_product_criteria_semaphore -> sale_commission_oca_product_criteria_semaphore#5577

Merged
OCA-git-bot merged 2 commits into
OCA:18.0from
Tecnativa:18.0-imp-sale_commission_product_criteria_semaphore
Apr 13, 2026
Merged

[18.0][IMP] apriori: sale_commission_product_criteria_semaphore -> sale_commission_oca_product_criteria_semaphore#5577
OCA-git-bot merged 2 commits into
OCA:18.0from
Tecnativa:18.0-imp-sale_commission_product_criteria_semaphore

Conversation

@CarlosRoca13

@CarlosRoca13 CarlosRoca13 commented Apr 6, 2026

Copy link
Copy Markdown

@david-banon-tecnativa

david-banon-tecnativa commented Apr 6, 2026

Copy link
Copy Markdown

Can you also add sale_commission_product_criteria -> sale_commission_oca_product_criteria?

@CarlosRoca13

CarlosRoca13 commented Apr 6, 2026

Copy link
Copy Markdown
Author

Sure

@CarlosRoca13 CarlosRoca13 force-pushed the 18.0-imp-sale_commission_product_criteria_semaphore branch from cc9a09d to 235ae25 Compare April 6, 2026 11:54
@CarlosRoca13

CarlosRoca13 commented Apr 6, 2026

Copy link
Copy Markdown
Author

Done @david-banon-tecnativa

david-banon-tecnativa
david-banon-tecnativa approved these changes Apr 6, 2026
View reviewed changes

@david-banon-tecnativa david-banon-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I don't think the test failures are related to this PR

@pedrobaeza

pedrobaeza commented Apr 6, 2026

Copy link
Copy Markdown
Member

The idea behind the _oca suffix is to go at the end. I see that one module was already merged, but I'm not even sure if this should have the suffix at all, as the intention is to avoid collisions with Odoo core names, but in this case, it's very unlikely. For example, sale_commission_salesman hasn't been renamed.

@pedrobaeza

pedrobaeza commented Apr 7, 2026

Copy link
Copy Markdown
Member

As the module is merged, let's keep it as is.

@pedrobaeza pedrobaeza added this to the 18.0 milestone Apr 7, 2026
@hbrunn

hbrunn commented Apr 13, 2026

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-5577-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a304068 into OCA:18.0 Apr 13, 2026
1 of 2 checks passed
@OCA-git-bot

OCA-git-bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at a304068. Thanks a lot for contributing to OCA. ❤️

@JordiMForgeFlow JordiMForgeFlow mentioned this pull request May 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

+1 more reviewer

@david-banon-tecnativa david-banon-tecnativa david-banon-tecnativa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

6 participants

@CarlosRoca13 @david-banon-tecnativa @pedrobaeza @hbrunn @OCA-git-bot @MiquelRForgeFlow
⚡