[REM] l10n_it_riba: It is already named l10n_it_riba_oca

[SirPyTech]

The rename has been merged a few days ago: OCA/l10n-italy#4856.

[sergiocorato]

Please respect commit name guide-line, like [18.0][OU-FIX] etc
Thanks

[SirPyTech]

Thanks for having a look!

Please respect commit name guide-line, like [18.0][OU-FIX] etc
Thanks

There is no specific guideline for this project's commit name, see https://github.com/OCA/OpenUpgrade/blob/18.0/CONTRIBUTING.md#project-specific-guidelines:

This project does not have specific coding guidelines.

but looks like everyone is creating their own instead 🤔

So I followed the usual guidelines in https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst; I changed the commit message anyway because [IMP] seems more appropriate.

[sergiocorato]

Thanks for having a look!

Please respect commit name guide-line, like [18.0][OU-FIX] etc
Thanks

There is no specific guideline for this project's commit name, see https://github.com/OCA/OpenUpgrade/blob/18.0/CONTRIBUTING.md#project-specific-guidelines:

This project does not have specific coding guidelines.

but looks like everyone is creating their own instead 🤔

So I followed the usual guidelines in https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst; I changed the commit message anyway because [IMP] seems more appropriate.

This is probably a not written recent guideline, see #5098 (comment)

[remi-filament]

Thanks for your PR @SirPyTech
You are right there is no guideline for commit as there are divergent view whether OU- should be added between brackets or not.
From my pov, this should be a FIX rather than a IMP and should not mention openupgrade_scripts but apriori instead.

Also it is useful for reviewers if you can add version number in PR name, [18.0]...

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[pedrobaeza]

This rename in 16 then seems incorrect:

https://github.com/OCA/OpenUpgrade/blob/16.0/openupgrade_scripts/apriori.py#L66

Isn't it?

[SirPyTech]

This rename in 16 then seems incorrect:

https://github.com/OCA/OpenUpgrade/blob/16.0/openupgrade_scripts/apriori.py#L66

Isn't it?

Thanks for having a look!

Let me summarize the situation first:

• 14.0: l10n_it_ricevute_bancarie (https://github.com/OCA/l10n-italy/tree/14.0/l10n_it_ricevute_bancarie)
• 16.0: l10n_it_riba_oca (https://github.com/OCA/l10n-italy/tree/16.0/l10n_it_riba_oca)
  This was renamed from l10n_it_riba with the PR Rinomina modulo ‎l10n_it_riba -> l10n_it_riba_oca l10n-italy#4856 (linked in description)
• 18.0: l10n_it_riba_oca (https://github.com/OCA/l10n-italy/tree/18.0/l10n_it_riba_oca)

So the rename you linked for 16.0:

"l10n_it_ricevute_bancarie": "l10n_it_riba_oca",

is actually correct.

And remember that all this mess is because Odoo added an enterprise module named l10n_it_riba in 16.0 😇

[SirPyTech]

From my pov, this should be a FIX rather than a IMP and should not mention openupgrade_scripts but apriori instead.

Thanks for having a look!
I understand, but in the commit title I just mentioned the module and why the change happened, the detailed implementation (editing apriori) is already shown in the commit's content; thanks for approving either way.

Also it is useful for reviewers if you can add version number in PR name, [18.0]...

I don't really like repeating the version information in multiple places, because we already have that same information in the base branch and now also in a dedicated label; I feel like adding it in the PR title is redundant.
I review PRs too and feel like the version in the PR title is not needed.

[pedrobaeza]

OK, let's continue and let the commit message aside.

[SirPyTech]

OK, let's continue and let the commit message aside.

Thanks! 🙏